Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #151 #152

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Issue #151 #152

merged 2 commits into from
Sep 16, 2022

Conversation

phatsk
Copy link
Contributor

@phatsk phatsk commented Feb 20, 2020 •
edited
Loading

Description of the Change

Updates relevant documentation. See #151

@phatsk
Issue 10up#151
d4a59d6 
- Fix sample test case method signatures.
@phatsk phatsk mentioned this pull request Feb 20, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.367% when pulling d4a59d6 on phatsk:issue-151 into 9927f0c on 10up:master.

@jeffpaul jeffpaul linked an issue Jul 14, 2020 that may be closed by this pull request
README.md sample test case is incompatible with mock class #151
Closed
@jeffpaul jeffpaul requested a review from ericmann July 14, 2020 03:54
@jeffpaul jeffpaul added this to the 0.4.3 milestone Jul 14, 2020
@jeffpaul jeffpaul added the Documentation Updates to documentation label Jul 14, 2020
unfulvio-godaddy
unfulvio-godaddy approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unfulvio-godaddy unfulvio-godaddy removed the request for review from ericmann September 16, 2022 01:46
@unfulvio-godaddy unfulvio-godaddy merged commit c2cb5d9 into 10up:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unfulvio-godaddy unfulvio-godaddy unfulvio-godaddy approved these changes

Assignees

@phatsk phatsk

Labels
Documentation Updates to documentation
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

README.md sample test case is incompatible with mock class
4 participants
@phatsk @coveralls @unfulvio-godaddy @jeffpaul