Refactor else / elif when if block has a raise statement (Sourcery refactored)
#24
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
…atement (#1) Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
| if isinstance(obj, datetime): | ||
| encoded_object = obj.strftime("%s") | ||
| else: | ||
| encoded_object = super(self, obj) | ||
| return encoded_object | ||
| return obj.strftime("%s") if isinstance(obj, datetime) else super(self, obj) |
There was a problem hiding this comment.
Function DateTimeEncoder.default refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| if x_forwarded_for: | ||
| ip = x_forwarded_for.split(",")[0] | ||
| else: | ||
| ip = request.META.get("REMOTE_ADDR") | ||
| return ip | ||
| return ( | ||
| x_forwarded_for.split(",")[0] | ||
| if x_forwarded_for | ||
| else request.META.get("REMOTE_ADDR") | ||
| ) |
There was a problem hiding this comment.
Function get_client_ip refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| if not len(recip) > 0: | ||
| if not recip: |
There was a problem hiding this comment.
Function send_message refactored with the following changes:
- Simplify sequence comparison (
simplify-len-comparison)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 1.85%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 15.63% 15.86% +0.22%
==========================================
Files 11 11
Lines 422 416 -6
==========================================
Hits 66 66
+ Misses 356 350 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Pull Request #23 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!