Skip to content

Commit a861472

Browse files
DarkLight13370xrushi
authored andcommitted
[Bugfix] Fix SLA tuner initialization (vllm-project#27355)
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
1 parent 718433e commit a861472

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

vllm/benchmarks/sweep/serve.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ def run_benchmark(
6666
):
6767
benchmark_cmd = [
6868
*bench_overrides.apply_to_cmd(bench_cmd),
69+
"--percentile-metrics",
70+
"ttft,tpot,itl,e2el",
6971
"--save-result",
7072
"--result-dir",
7173
str(output_path.parent),

vllm/benchmarks/sweep/serve_sla.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,8 @@ class SweepServeSLAArgs(SweepServeArgs):
401401

402402
@classmethod
403403
def from_cli_args(cls, args: argparse.Namespace):
404-
base_args = super().from_cli_args(args)
404+
# NOTE: Don't use super() as `from_cli_args` calls `cls()`
405+
base_args = SweepServeArgs.from_cli_args(args)
405406

406407
if args.sla_params:
407408
sla_params = SLASweep.read_json(args.sla_params)

0 commit comments

Comments
 (0)