Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EasyScore with a ShadowRoot element #793

Open
ywsang opened this issue Jun 10, 2020 · 0 comments
Open

Use EasyScore with a ShadowRoot element #793

ywsang opened this issue Jun 10, 2020 · 0 comments
Labels

Comments

@ywsang
Copy link

ywsang commented Jun 10, 2020

Hi! I'm interested in using the EasyScore API to a <div> element inside a ShadowRoot. Right now, this doesn't appear possible because the Factory takes in just an elementId, and the underlying code uses document.getElementById(elementId) to create the Renderer.

I tested creating a Renderer following the native API and passing it in the Factory constructor, but that seems to result in an extra blank svg area being created.

I'd be interested in trying to modify the code such that using ShadowRoot elements with EasyScore is also possible, whether that be by passing the actual element or passing in what scope the Renderer should look for the element (document versus shadowRoot). However, I noticed that the Factory, which includes the elementId gets passed around quite a bit, and wanted to ask those with more context how complicated a change like this might be.

@ronyeh ronyeh added the future label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants