Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cross staff chords #434

Open
Silverwolf90 opened this issue Aug 28, 2016 · 3 comments
Open

Support cross staff chords #434

Silverwolf90 opened this issue Aug 28, 2016 · 3 comments

Comments

@Silverwolf90
Copy link
Contributor

image

@0xfe
Copy link
Owner

0xfe commented Aug 28, 2016

I think we could treat this as multiple distinct StaveNotes and add some mechanism to connect the stems.

@Silverwolf90
Copy link
Contributor Author

While a good graphical solution, representing this single StaveNote as two independent StaveNotes puts a big burden on Voice construction by requiring extra voices with complementary GhostNotes.

In my experience, a cross-staff chord is not a particularly more complicated case than a single staff chord -- the codepath for both would ideally be nearly, if not completely, identical. Noteheads already have a setStave method, which is set to the same stave as the parent StaveNote when setStave is called. There's also logic in places that assume that all noteheads are on the same staff, but taking into account potentially different staves doesn't complicate things much.

I'd guess that if stems were a bit bit smarter, formatting occurred in consistent parts of the lifecycle, and the StaveNote delegated to the stem and noteheads wherever possible (ie: deprecate staveNote.ys), then this should be straightforward to support.

@hoangtranwork
Copy link

Hello, is there any news on this lately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants