-
Notifications
You must be signed in to change notification settings - Fork 77
[ON HOLD] Speed up startup by precalculating hashes and precompiling contracts #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be minified
| serde_json = { workspace = true } | ||
| blake3 = "1.5" | ||
| usc = { workspace = true } | ||
| serde_json_canonicalizer = "0.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in the root Cargo.toml? Applies to L26 and L61.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does removing debug data affect behavior on error and the available stack trace?
| sierra_contract_json: serde_json::Value, | ||
| sierra_contract_json: Value, | ||
| ) -> DevnetResult<CasmContractClass> { | ||
| #[cfg(not(clippy))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this line necessary?
9f1da3e to
a3e975f
Compare
ON HOLD until Blake hashing is implemented.
Usage related changes
Faster devnet startup
Development related changes
To recap, following changes are made, as diffs are bit unreliable in some parts
Resolves #804.
TODOs:
Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md