Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Adapt to JSON RPC API spec v0.3.0 #476

Closed
FabijanC opened this issue May 20, 2023 · 3 comments · Fixed by #494
Closed

Adapt to JSON RPC API spec v0.3.0 #476

FabijanC opened this issue May 20, 2023 · 3 comments · Fixed by #494
Assignees
@bartekryba
Labels
Duration: few days will take a few days Techno: python Python Type: feature New feature or request

Comments

@FabijanC
Copy link
Collaborator

Currently adapted to v0.3.0-rc1
@FabijanC FabijanC added Type: feature New feature or request Techno: python Python Duration: few days will take a few days labels May 20, 2023
@bartekryba
Copy link
Contributor

Hey, I'll take care of that

@mikiw
Copy link
Contributor

mikiw commented May 31, 2023

Hi @bartekryba so in rpc_spec.py we have # All usages of "oneOf" have been replaced by "anyOf". What was the motivation behind that? Devnet was not working properly with "oneOf"?

@bartekryba bartekryba mentioned this issue Jun 1, 2023
Merged
8 tasks
@bartekryba
Copy link
Contributor

Yes, for some reason jsonschema validation fails in some places with oneOf, but works with anyOf

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in starknet-devnet Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bartekryba bartekryba

Labels
Duration: few days will take a few days Techno: python Python Type: feature New feature or request
Projects
No open projects
starknet-devnet
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rpc v0.3.0 update bartekryba/starknet-devnet
3 participants
@mikiw @bartekryba @FabijanC