refactor: resolve access to static objects via object references

Author: 0xDVC

mnotify-sms-javaclient/pom.xml

@@ -24,7 +24,11 @@
             <version>4.12.0</version>
         </dependency>
 
-    // Jackson?? or GSON??
+        <dependency>
+            <groupId>com.google.code.gson</groupId>
+            <artifactId>gson</artifactId>
+            <version>2.11.0</version>
+        </dependency>
 
     </dependencies>
 

mnotify-sms-javaclient/src/main/java/com/mnotify/MnotifyClientConfiguration.java

@@ -1,7 +1,7 @@
 package com.mnotify;
 
 final class MnotifyClientConfiguration {
-    public static MnotifyClient buildClientFrom(String secretKey) {
-        return new MnotifyClient.Impl(secretKey);
+    public static MnotifyClient buildClientFrom(String apiKey) {
+        return new MnotifyClient.Impl(apiKey);
     }
 }

mnotify-sms-javaclient/src/main/java/com/mnotify/definitions/Campaign.java

@@ -7,7 +7,6 @@
 import okhttp3.*;
 
 import java.io.File;
-
 import java.time.LocalDateTime;
 
 import java.util.List;
@@ -37,7 +36,7 @@ public JsonElement quickBulkSMS(List<String> recipients,
                 .add("scheduled_date", String.valueOf(scheduledDate))
                 .build();
 
-        builder.URL = URLDefinitions.QUICK_BULK_SMS;
+        RequestBuilder.URL = URLDefinitions.QUICK_BULK_SMS;
         Request request = builder.buildRequestWithBody(requestBody);
         return RequestExecutor.executeRequest(request);
     }
@@ -63,7 +62,7 @@ public JsonElement groupBulkSMS(List<String> groupIds,
     }
 
     public JsonElement scheduledSMS() {
-        builder.URL = URLDefinitions.SCHEDULED_SMS;
+        RequestBuilder.URL = URLDefinitions.SCHEDULED_SMS;
         Request request = builder.buildRequest();
         return RequestExecutor.executeRequest(request);
     }
@@ -102,7 +101,7 @@ public JsonElement quickBulkVoiceCall(
                 .addFormDataPart("schedule_date", scheduleDate.toString())
                 .build();
 
-        builder.URL = URLDefinitions.QUICK_BULK_VOICE_CALL;
+        RequestBuilder.URL = URLDefinitions.QUICK_BULK_VOICE_CALL;
         Request request = builder.buildRequestWithBody(multipartBody);
 
         return RequestExecutor.executeRequest(request);
@@ -128,7 +127,7 @@ public JsonElement groupBulkVoiceCall(
                 .addFormDataPart("schedule_date", scheduleDate.toString())
                 .build();
 
-        builder.URL = URLDefinitions.GROUP_BULK_VOICE_CALL;
+        RequestBuilder.URL = URLDefinitions.GROUP_BULK_VOICE_CALL;
         Request request = builder.buildRequestWithBody(multipartBody);
 
         return RequestExecutor.executeRequest(request);
@@ -139,7 +138,7 @@ public JsonElement senderIdRegistration(String sender, String purpose) {
                 .add("sender_name", sender)
                 .add("purpose", purpose)
                 .build();
-        builder.URL = URLDefinitions.SENDER_ID_REGISTRATION;
+        RequestBuilder.URL = URLDefinitions.SENDER_ID_REGISTRATION;
         Request request = builder.buildRequestWithBody(requestBody);
 
         return RequestExecutor.executeRequest(request);
@@ -150,7 +149,7 @@ public JsonElement checkSenderIdStatus(String sender) {
                 .add("sender_name", sender)
                 .build();
 
-        builder.URL = URLDefinitions.SENDER_ID_STATUS;
+        RequestBuilder.URL = URLDefinitions.SENDER_ID_STATUS;
         Request request = builder.buildRequestWithBody(requestBody);
 
         return RequestExecutor.executeRequest(request);

mnotify-sms-javaclient/src/main/java/com/mnotify/definitions/Contact.java

@@ -12,6 +12,7 @@
 @SuppressWarnings(value = "unused")
 public class Contact {
     RequestBuilder builder;
+
     public Contact() {
         builder = new RequestBuilder(URLDefinitions.CONTACT_ENDPOINT);
     }