Skip to content

Commit

Permalink
chore: Require VS Code ^1.86
Browse files Browse the repository at this point in the history
This bumps minimum required GLIBC to 2.28, which we use in Slang.
  • Loading branch information
Xanewok authored and kanej committed Apr 17, 2024
1 parent c550d8a commit 5b7299f
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
cache-name: cache-vscode
with:
path: .vscode-test
key: ${{ runner.os }}-vscode-1.70.2
key: ${{ runner.os }}-vscode-1.86.0

- name: Run E2E tests
uses: coactions/setup-xvfb@v1.0.1
Expand Down
4 changes: 2 additions & 2 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"url": "https://github.com/NomicFoundation/hardhat-vscode/issues"
},
"engines": {
"vscode": "^1.70.2"
"vscode": "^1.86.0"
},
"activationEvents": [
"onLanguage:solidity",
Expand All @@ -58,7 +58,7 @@
"devDependencies": {
"@sentry/types": "6.19.1",
"@types/prettier": "2.6.0",
"@types/vscode": "^1.70",
"@types/vscode": "^1.86",
"eslint": "^7.23.0",
"rimraf": "3.0.2",
"prettier": "2.5.1"
Expand Down
19 changes: 11 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@types/glob": "^7.1.3",
"@types/mocha": "^8.2.2",
"@types/module-alias": "2.0.1",
"@types/vscode": "^1.70",
"@types/vscode": "^1.86",
"@typescript-eslint/eslint-plugin": "5.8.0",
"@typescript-eslint/parser": "5.8.0",
"@vscode/test-electron": "2.3.8",
Expand Down
2 changes: 1 addition & 1 deletion test/runTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { runTests } from "@vscode/test-electron";

// Download VS Code, unzip it and run the e2e test
await runTests({
version: "1.70.2",
version: "1.86.0",
extensionDevelopmentPath,
extensionTestsPath,

Expand Down

0 comments on commit 5b7299f

Please sign in to comment.