Skip to content

Commit 41996d0

Browse files
authored
Mocha 7.0.1 (xpring-eng#48)
Upgrade eslint-plugin-mocha and @typescript-eslint. Now require only one describe block per test file, and require a description in a @ts-expect-error comment.
1 parent e3596e7 commit 41996d0

File tree

4 files changed

+61
-75
lines changed

4 files changed

+61
-75
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,17 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
99

1010
## [Unreleased]
1111

12+
## 0.5.2 - June 1, 2020
13+
14+
- Require `@typescript-eslint: v3.1.0`, which improves some rules detection capabilities, and allows requiring descriptions for `@ts-*` comments.
15+
- Require `eslint-plugin-mocha: v7.0.1`, which fixes a bug in `max-top-level-suites`, so the rule actually works.
16+
17+
This may result in new linting violations.
18+
19+
## 0.5.1 - May 28, 2020
20+
21+
Add `eslint-plugin-eslint-comments` as a peer dependency.
22+
1223
## 0.5.0 - May 28, 2020
1324

1425
Add `eslint-plugin-eslint-comments` to our linting configuration.

package-lock.json

Lines changed: 40 additions & 67 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@xpring-eng/eslint-config-base",
3-
"version": "0.5.1",
3+
"version": "0.5.2",
44
"description": "Xpring's base TS ESLint config, following our styleguide",
55
"main": "index.js",
66
"scripts": {
@@ -27,26 +27,26 @@
2727
"eslint-config-prettier": "^6.11.0"
2828
},
2929
"peerDependencies": {
30-
"@typescript-eslint/eslint-plugin": "^3.0.1",
31-
"@typescript-eslint/parser": "^3.0.1",
30+
"@typescript-eslint/eslint-plugin": "^3.1.0",
31+
"@typescript-eslint/parser": "^3.1.0",
3232
"eslint": ">= 7",
3333
"eslint-plugin-eslint-comments": "^3.2.0",
3434
"eslint-plugin-import": "^2.20.2",
35-
"eslint-plugin-mocha": "^7.0.0",
35+
"eslint-plugin-mocha": "^7.0.1",
3636
"eslint-plugin-node": "^11.1.0",
3737
"eslint-plugin-prettier": "^3.1.3",
3838
"eslint-plugin-tsdoc": "^0.2.5",
3939
"prettier": "^2.0.5",
4040
"typescript": "^3.9.2"
4141
},
4242
"devDependencies": {
43-
"@typescript-eslint/eslint-plugin": "^3.0.1",
44-
"@typescript-eslint/parser": "^3.0.1",
43+
"@typescript-eslint/eslint-plugin": "^3.1.0",
44+
"@typescript-eslint/parser": "^3.1.0",
4545
"eslint": "^7.0.0",
4646
"eslint-find-rules": "^3.4.0",
4747
"eslint-plugin-eslint-comments": "^3.2.0",
4848
"eslint-plugin-import": "^2.20.2",
49-
"eslint-plugin-mocha": "^7.0.0",
49+
"eslint-plugin-mocha": "^7.0.1",
5050
"eslint-plugin-node": "^11.1.0",
5151
"eslint-plugin-prettier": "^3.1.3",
5252
"eslint-plugin-tsdoc": "^0.2.5",

rules/@typescript-eslint.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ module.exports = {
3838
'ts-ignore': true,
3939
'ts-nocheck': true,
4040
'ts-check': false,
41+
minimumDescriptionLength: 4,
4142
},
4243
],
4344

@@ -735,10 +736,11 @@ module.exports = {
735736
'@typescript-eslint/ban-ts-comment': [
736737
'error',
737738
{
738-
'ts-expect-error': false,
739+
'ts-expect-error': 'allow-with-description',
739740
'ts-ignore': true,
740741
'ts-nocheck': true,
741742
'ts-check': false,
743+
minimumDescriptionLength: 4,
742744
},
743745
],
744746
},

0 commit comments

Comments
 (0)