Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #8

Merged
merged 2 commits into from
May 1, 2020
Merged

Update README.md #8

merged 2 commits into from
May 1, 2020

Conversation

shkrt
Copy link
Contributor

@shkrt shkrt commented Apr 30, 2020

Fix broken link to resdet.h

Fix broken link to resdet.h
Copy link
Owner

@0x09 0x09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

README.md Outdated
@@ -37,7 +37,7 @@ See resdet -h for more options.

# API

resdet can be used as a library by including [resdet.h](resdet.h) and linking with libresdet. To install the library, use `make install-lib` after building.
resdet can be used as a library by including [resdet.h](https://github.com/0x09/resdet/blob/master/include/resdet.h) and linking with libresdet. To install the library, use `make install-lib` after building.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this as a relative link so this will work in forks too? Right now github turns [resdet.h](resdet.h) into https://github.com/0x09/resdet/blob/master/resdet.h, so it may just be a matter of adding in the include/ prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @0x09

@0x09 0x09 merged commit 29e0542 into 0x09:master May 1, 2020
@shkrt shkrt deleted the patch-1 branch May 1, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants