Skip to content

Commit dfb00a5

Browse files
takaswietiwai
authored andcommitted
ALSA: firewire-lib: fix inappropriate assignment between signed/unsigned type
An abstraction of asynchronous transaction for transmission of MIDI messages was introduced in Linux v4.4. Each driver can utilize this abstraction to transfer MIDI messages via fixed-length payload of transaction to a certain unit address. Filling payload of the transaction is done by callback. In this callback, each driver can return negative error code, however current implementation assigns the return value to unsigned variable. This commit changes type of the variable to fix the bug. Reported-by: Julia Lawall <Julia.Lawall@lip6.fr> Cc: <stable@vger.kernel.org> # 4.4+ Fixes: 585d7cb ("ALSA: firewire-lib: add helper functions for asynchronous transactions to transfer MIDI messages") Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 4e7655f commit dfb00a5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/firewire/lib.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ struct snd_fw_async_midi_port {
4545

4646
struct snd_rawmidi_substream *substream;
4747
snd_fw_async_midi_port_fill fill;
48-
unsigned int consume_bytes;
48+
int consume_bytes;
4949
};
5050

5151
int snd_fw_async_midi_port_init(struct snd_fw_async_midi_port *port,

0 commit comments

Comments
 (0)