From 3e876260a42b9ec12e97fcc38d4c65b47fbe5efc Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Wed, 9 Nov 2016 13:03:46 +1100 Subject: [PATCH] mm-unexport-__get_user_pages_unlocked-checkpatch-fixes ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 0123456789ab ("commit description")' #16: flag. However, this flag was originally silently dropped by 1e9877902dc7e WARNING: line over 80 characters #89: FILE: mm/nommu.c:179: +static long __get_user_pages_unlocked(struct task_struct *tsk, struct mm_struct *mm, WARNING: line over 80 characters #90: FILE: mm/nommu.c:180: + unsigned long start, unsigned long nr_pages, WARNING: line over 80 characters #91: FILE: mm/nommu.c:181: + struct page **pages, unsigned int gup_flags) ERROR: code indent should use tabs where possible #91: FILE: mm/nommu.c:181: +^I^I^I struct page **pages, unsigned int gup_flags)$ total: 2 errors, 3 warnings, 116 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/mm-unexport-__get_user_pages_unlocked.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Lorenzo Stoakes <lstoakes@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- mm/nommu.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index 669437b16c7f7e..4eaea8f0a572cb 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -176,9 +176,10 @@ long get_user_pages_locked(unsigned long start, unsigned long nr_pages, } EXPORT_SYMBOL(get_user_pages_locked); -static long __get_user_pages_unlocked(struct task_struct *tsk, struct mm_struct *mm, - unsigned long start, unsigned long nr_pages, - struct page **pages, unsigned int gup_flags) +static long __get_user_pages_unlocked(struct task_struct *tsk, + struct mm_struct *mm, unsigned long start, + unsigned long nr_pages, struct page **pages, + unsigned int gup_flags) { long ret; down_read(&mm->mmap_sem);