Skip to content

Commit

Permalink
mm-unexport-__get_user_pages_unlocked-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
torvalds#16:
flag.  However, this flag was originally silently dropped by 1e98779

WARNING: line over 80 characters
torvalds#89: FILE: mm/nommu.c:179:
+static long __get_user_pages_unlocked(struct task_struct *tsk, struct mm_struct *mm,

WARNING: line over 80 characters
torvalds#90: FILE: mm/nommu.c:180:
+				      unsigned long start, unsigned long nr_pages,

WARNING: line over 80 characters
torvalds#91: FILE: mm/nommu.c:181:
+			              struct page **pages, unsigned int gup_flags)

ERROR: code indent should use tabs where possible
torvalds#91: FILE: mm/nommu.c:181:
+^I^I^I              struct page **pages, unsigned int gup_flags)$

total: 2 errors, 3 warnings, 116 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

./patches/mm-unexport-__get_user_pages_unlocked.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Lorenzo Stoakes <lstoakes@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed Nov 30, 2016
1 parent 0d798ac commit 1294df7
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions mm/nommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,10 @@ long get_user_pages_locked(unsigned long start, unsigned long nr_pages,
}
EXPORT_SYMBOL(get_user_pages_locked);

static long __get_user_pages_unlocked(struct task_struct *tsk, struct mm_struct *mm,
unsigned long start, unsigned long nr_pages,
struct page **pages, unsigned int gup_flags)
static long __get_user_pages_unlocked(struct task_struct *tsk,
struct mm_struct *mm, unsigned long start,
unsigned long nr_pages, struct page **pages,
unsigned int gup_flags)
{
long ret;
down_read(&mm->mmap_sem);
Expand Down

0 comments on commit 1294df7

Please sign in to comment.