Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use size diff from root ref #1460

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

Conversation

Hitenjain14
Copy link
Member

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 14.79%. Comparing base (e5018a7) to head (16e6dd0).
Report is 93 commits behind head on staging.

Files Patch % Lines
...et/blobbercore/handler/object_operation_handler.go 0.00% 21 Missing ⚠️
...ain.net/blobbercore/allocation/allocationchange.go 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1460      +/-   ##
===========================================
- Coverage    14.88%   14.79%   -0.10%     
===========================================
  Files          179      180       +1     
  Lines        20222    20218       -4     
===========================================
- Hits          3011     2991      -20     
- Misses       16839    16857      +18     
+ Partials       372      370       -2     
Flag Coverage Δ
Unit-Tests 14.79% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants